Skip to content

Fix some compiler conditional uses (SWT_NO_*). #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2024
Merged

Fix some compiler conditional uses (SWT_NO_*). #782

merged 1 commit into from
Oct 25, 2024

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Oct 24, 2024 •
edited
Loading

This PR fixes a few edge cases where combinations of feature-disabling compiler conditionals would make the build fail.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan
Fix some compiler conditional uses (SWT_NO_*).
711b213 
This PR fixes a few edge cases where combinations of feature-disabling compiler
conditionals would make the build fail.
@grynspan grynspan added bug 🪲 Something isn't working embedded-swift 📟 Embedded Swift issues build 🧱 Affects the project's build configuration or process labels Oct 24, 2024
@grynspan grynspan self-assigned this Oct 24, 2024
@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan
Copy link
Contributor Author

Self-reviewing.

@grynspan grynspan added the self-reviewed PR was self-reviewed by a code owner label Oct 25, 2024
@grynspan grynspan merged commit 3fb80df into main Oct 25, 2024
3 checks passed
@grynspan grynspan deleted the jgrynspan/conditional-fixes branch October 25, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmontgomery stmontgomery Awaiting requested review from stmontgomery stmontgomery is a code owner

@dennisweissmann dennisweissmann Awaiting requested review from dennisweissmann

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@grynspan grynspan

Labels
bug 🪲 Something isn't working build 🧱 Affects the project's build configuration or process embedded-swift 📟 Embedded Swift issues self-reviewed PR was self-reviewed by a code owner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@grynspan